Thread (12 messages) 12 messages, 7 authors, 2016-05-12

Re: [PATH v2] NVMe: init nvme queue before enabling irq

From: Johannes Thumshirn <hidden>
Date: 2016-05-10 09:13:37
Also in: lkml

On Wed, Jan 20, 2016 at 10:17:10AM -0700, Jens Axboe wrote:
On 01/20/2016 10:12 AM, Greg KH wrote:
quoted
On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote:
quoted
From: Wenbo Wang <redacted>

During reset process, the nvme_dev->bar (ioremapped) may change,
so nvmeq->q_db shall be also updated by nvme_init_queue().

Currently nvmeq irq is enabled before queue init, so a spurious
interrupt triggered nvme_process_cq may access nvmeq->q_db just
before it is updated, this could cause kernel panic.

Signed-off-by: Wenbo Wang <redacted>
Reviewed-by: Wenwei Tao <redacted>
---
  drivers/nvme/host/pci.c | 14 +++++++++-----
  1 file changed, 9 insertions(+), 5 deletions(-)
<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
I'll mark it stable when adding, just ignore it for now.

-- 
Jens Axboe


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Ping?

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help