Thread (12 messages) 12 messages, 7 authors, 2016-05-12

Re: [PATH v2] NVMe: init nvme queue before enabling irq

From: Keith Busch <hidden>
Date: 2016-01-20 14:57:44
Also in: linux-nvme, lkml

On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote:
From: Wenbo Wang <redacted>

During reset process, the nvme_dev->bar (ioremapped) may change,
so nvmeq->q_db shall be also updated by nvme_init_queue().

Currently nvmeq irq is enabled before queue init, so a spurious
interrupt triggered nvme_process_cq may access nvmeq->q_db just
before it is updated, this could cause kernel panic.

Signed-off-by: Wenbo Wang <redacted>
Reviewed-by: Wenwei Tao <redacted>
Looks good, thanks for the fix.

Acked-by: Keith Busch <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help