Thread (347 messages) flat view 347 messages, 3 authors, 2016-03-02
STALE3842d REVIEWED: 1 (0M)

1 review trailer.

[PATCH 4.4 128/342] irqchip/atmel-aic: Fix wrong bit operation for IRQ priority

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2016-03-02 00:52:00
Also in: lkml

4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Milo Kim <redacted>

commit 49f34134aea74f19ca016f055d25ee55ec359dee upstream.

Atmel AIC has common structure for SMR (Source Mode Register).

  bit[6:5] Interrupt source type
  bit[2:0] Priority level
  Other bits are unused.

To update new priority value, bit[2:0] should be cleared first and then
new priority level can be written. However, aic_common_set_priority()
helper clears source type bits instead of priority bits.
This patch fixes wrong mask bit operation.

Fixes: b1479ebb7720 "irqchip: atmel-aic: Add atmel AIC/AIC5 drivers"
Signed-off-by: Milo Kim <redacted>
Acked-by: Boris Brezillon <redacted>
Cc: Jason Cooper <redacted>
Cc: Marc Zyngier <redacted>
Cc: Ludovic Desroches <redacted>
Cc: Nicholas Ferre <redacted>
Link: http://lkml.kernel.org/r/1452669592-3401-2-git-send-email-milo.kim@ti.com
Signed-off-by: Thomas Gleixner <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/irqchip/irq-atmel-aic-common.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/irqchip/irq-atmel-aic-common.c
+++ b/drivers/irqchip/irq-atmel-aic-common.c
@@ -86,7 +86,7 @@ int aic_common_set_priority(int priority
 	    priority > AT91_AIC_IRQ_MAX_PRIORITY)
 		return -EINVAL;
 
-	*val &= AT91_AIC_PRIOR;
+	*val &= ~AT91_AIC_PRIOR;
 	*val |= priority;
 
 	return 0;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help