Thread (347 messages) flat view 347 messages, 3 authors, 2016-03-02
STALE3853d REVIEWED: 1 (0M)

1 review trailer.

[PATCH 4.4 284/342] spi: atmel: fix gpio chip-select in case of non-DT platform

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2016-03-02 00:18:59
Also in: lkml

4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Cyrille Pitchen <redacted>

commit 70f340df24518d36eeaefb6652d492f250115c19 upstream.

The non-DT platform that uses this driver (actually the AVR32) was taking a bad
branch for determining if the IP would use gpio for CS.
Adding the presence of DT as a condition fixes this issue.

Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller")
Reported-by: Mans Rullgard <redacted>
Signed-off-by: Cyrille Pitchen <redacted>
[nicolas.ferre@atmel.com: extract from ml discussion]
Signed-off-by: Nicolas Ferre <redacted>
Tested-by: Mans Rullgard <redacted>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/spi/spi-atmel.c |    1 +
 1 file changed, 1 insertion(+)
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platfo
 
 	as->use_cs_gpios = true;
 	if (atmel_spi_is_v2(as) &&
+	    pdev->dev.of_node &&
 	    !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
 		as->use_cs_gpios = false;
 		master->num_chipselect = 4;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help