[PATCH 3.12 045/176] scripts/kernel-doc: don't eat struct members with __aligned
From: Jiri Slaby <hidden>
Date: 2015-01-29 10:19:25
Also in:
lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Jiri Slaby <hidden>
Date: 2015-01-29 10:19:25
Also in:
lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Johannes Berg <redacted>
3.12-stable review patch. If anyone has any objections, please let me know.
===============
commit 7b990789a4c3420fa57596b368733158e432d444 upstream.
The change from \d+ to .+ inside __aligned() means that the following
structure:
struct test {
u8 a __aligned(2);
u8 b __aligned(2);
};
essentially gets modified to
struct test {
u8 a;
};
for purposes of kernel-doc, thus dropping a struct member, which in
turns causes warnings and invalid kernel-doc generation.
Fix this by replacing the catch-all (".") with anything that's not a
semicolon ("[^;]").
Fixes: 9dc30918b23f ("scripts/kernel-doc: handle struct member __aligned without numbers")
Signed-off-by: Johannes Berg <redacted>
Cc: Nishanth Menon <nm@ti.com>
Cc: Randy Dunlap <redacted>
Cc: Michal Marek <redacted>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <redacted>
---
scripts/kernel-doc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kernel-doc b/scripts/kernel-doc
index 4305b2f2ec5e..8c0e07b7a70b 100755
--- a/scripts/kernel-doc
+++ b/scripts/kernel-doc@@ -1750,7 +1750,7 @@ sub dump_struct($$) { # strip kmemcheck_bitfield_{begin,end}.*; $members =~ s/kmemcheck_bitfield_.*?;//gos; # strip attributes - $members =~ s/__aligned\s*\(.+\)//gos; + $members =~ s/__aligned\s*\([^;]*\)//gos; create_parameterlist($members, ';', $file); check_sections($file, $declaration_name, "struct", $sectcheck, $struct_actual, $nested);
--
2.2.2