[PATCH 3.2 050/131] hwmon: (sis5595) Prevent overflow problem when writing large limits
From: Ben Hutchings <hidden>
Date: 2014-09-11 12:43:57
Also in:
lkml
From: Ben Hutchings <hidden>
Date: 2014-09-11 12:43:57
Also in:
lkml
3.2.63-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Axel Lin <redacted> commit cc336546ddca8c22de83720632431c16a5f9fe9a upstream. On platforms with sizeof(int) < sizeof(long), writing a temperature limit larger than MAXINT will result in unpredictable limit values written to the chip. Avoid auto-conversion from long to int to fix the problem. Signed-off-by: Axel Lin <redacted> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Ben Hutchings <redacted> --- drivers/hwmon/sis5595.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwmon/sis5595.c
+++ b/drivers/hwmon/sis5595.c@@ -149,7 +149,7 @@ static inline int TEMP_FROM_REG(s8 val) { return val * 830 + 52120; } -static inline s8 TEMP_TO_REG(int val) +static inline s8 TEMP_TO_REG(long val) { int nval = SENSORS_LIMIT(val, -54120, 157530) ; return nval<0 ? (nval-5212-415)/830 : (nval-5212+415)/830;