[040/264] target: Prevent transport_send_task_abort when CHECK_CONDITION status
From: Greg KH <gregkh@suse.de>
Date: 2011-11-10 04:36:34
Also in:
lkml
3.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicholas Bellinger <redacted> commit c252f003470a99d319db4ebd12f4a9e4710a65db upstream. This patch fixes a bug where transport_send_task_abort() could be called during LUN_RESET to return SAM_STAT_TASK_ABORTED + tfo->queue_status(), when SCF_SENT_CHECK_CONDITION -> tfo->queue_status() has already been sent from within another context via transport_send_check_condition_and_sense(). Signed-off-by: Nicholas Bellinger <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/target/target_core_transport.c | 9 +++++++++ 1 file changed, 9 insertions(+)
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c@@ -4920,6 +4920,15 @@ EXPORT_SYMBOL(transport_check_aborted_st void transport_send_task_abort(struct se_cmd *cmd) { + unsigned long flags; + + spin_lock_irqsave(&cmd->t_state_lock, flags); + if (cmd->se_cmd_flags & SCF_SENT_CHECK_CONDITION) { + spin_unlock_irqrestore(&cmd->t_state_lock, flags); + return; + } + spin_unlock_irqrestore(&cmd->t_state_lock, flags); + /* * If there are still expected incoming fabric WRITEs, we wait * until until they have completed before sending a TASK_ABORTED