Thread (265 messages) 265 messages, 1 author, 2011-11-10

[108/264] perf probe: Fix to show correct error string

From: Greg KH <gregkh@suse.de>
Date: 2011-11-10 03:40:34
Also in: lkml

3.1-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Masami Hiramatsu <redacted>

commit 44a56040a0037a845d5fa218dffde464579f0cab upstream.

Fix perf probe to show correct error string when it
fails to delete an event. The write(2) returns -1
if failed, and errno stores real error number.

Signed-off-by: Masami Hiramatsu <redacted>
Cc: Peter Zijlstra <redacted>
Cc: Arnaldo Carvalho de Melo <redacted>
Cc: Paul Mackerras <redacted>
Cc: Ingo Molnar <redacted>
Link: http://lkml.kernel.org/r/20111004104504.14591.41266.stgit@fedora15
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 tools/perf/util/probe-event.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -1956,8 +1956,10 @@ static int __del_trace_probe_event(int f
 
 	pr_debug("Writing event: %s\n", buf);
 	ret = write(fd, buf, strlen(buf));
-	if (ret < 0)
+	if (ret < 0) {
+		ret = -errno;
 		goto error;
+	}
 
 	printf("Remove event: %s\n", ent->s);
 	return 0;

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help