Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] devlink_alloc_drv() passes @dev straight to __devlink_alloc()
with no WARN_ON(!dev).
--
devlink: add devlink_alloc_drv()
This adds devlink_alloc_drv(), a variant of devlink_alloc() that takes the
owning driver explicitly. It is meant for a PF driver that creates devlink
instances for its VFs, where the VF device may be bound to another driver
or to none. The devlink-info documentation is updated to say the reported
driver is the creating driver in that case.
quoted hunk ↗ jump to hunk
diff --git a/net/devlink/core.c b/net/devlink/core.c
index 9b844e0c1bd2d..e2a7169287ec7 100644
--- a/net/devlink/core.c
+++ b/net/devlink/core.c
@@ -531,6 +531,30 @@ struct devlink *devlink_alloc_ns(const struct devlink_ops *ops,
}
EXPORT_SYMBOL_GPL(devlink_alloc_ns);
+/**
+ * devlink_alloc_drv - Allocate new devlink instance resources for given driver
+ * @ops: ops
+ * @priv_size: size of user private data
+ * @dev: parent device
+ * @drv: driver that owns the instance
+ *
+ * Variant of devlink_alloc() for a driver that creates an instance for
+ * a device bound to another (or no) driver, e.g. a PF driver for its VFs.
+ *
+ * @drv must not be NULL and must outlive the instance, only a pointer to it
+ * is kept. Operations that take the device lock, like reload, lock @dev,
+ * not a device bound to @drv.
+ *
+ * Return: new devlink instance, NULL on failure.
+ */
+struct devlink *devlink_alloc_drv(const struct devlink_ops *ops,
+ size_t priv_size, struct device *dev,
+ const struct device_driver *drv)
+{
+ return __devlink_alloc(ops, priv_size, &init_net, dev, drv);
+}
[Severity: Low]
This isn't a bug, but should devlink_alloc_drv() also have the
WARN_ON(!dev) that devlink_alloc_ns() has?
net/devlink/core.c:devlink_alloc_ns() {
WARN_ON(!dev);
return __devlink_alloc(ops, priv_size, net, dev, dev->driver);
}
The kernel-doc calls @dev the parent device and says reload locks @dev.
If @dev is NULL, __devlink_alloc() goes ahead and creates an index-named
instance, like the one devlink_shd_get() creates. Then devl_dev_lock()
skips the device lock without any warning:
net/devlink/devl_internal.h:devl_dev_lock() {
if (dev_lock && devlink->dev)
device_lock(devlink->dev);
devl_lock(devlink);
}
That doesn't match the kernel-doc.
The same applies to @drv. The kernel-doc says it must not be NULL, but a
NULL @drv only hits the WARN_ON(!ops || !dev_driver) in __devlink_alloc(),
and allocation continues.
The only current caller, ice_init_vf_devlink() in the next patch, returns
early when vf->vfdev is NULL, so no current path passes a NULL @dev. Could
a check for dev be added here (and maybe for drv too) so this variant
behaves like devlink_alloc_ns() and the kernel-doc?
+EXPORT_SYMBOL_GPL(devlink_alloc_drv);
+
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261117094913.100756-1-przemyslaw.kitszel%40intel.com