Re: [net-next v6 05/15] ice: rename ICE_MAX_RSS_QS_PER_VF to ICE_MAX_QS_PER_VF_VCV1

From
netdev-bot+sashiko@kernel.org
Date
2026-11-19 06:44:56
Reply to
Przemek Kitszel, 2026-11-17
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The rename marks every user of the old ICE_MAX_RSS_QS_PER_VF as a
  legacy virtchnl-v1 opcode limit.

--

ice: rename ICE_MAX_RSS_QS_PER_VF to ICE_MAX_QS_PER_VF_VCV1

This commit renames ICE_MAX_RSS_QS_PER_VF to ICE_MAX_QS_PER_VF_VCV1 across
the ice driver and keeps the value at 16. It prepares for the next patch,
which raises the per-VF queue maximum to 256. It also adjusts the
kernel-doc of ice_vf_has_no_qs_ena().
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.h b/drivers/net/ethernet/intel/ice/ice_vf_lib.h
index fa436b3b1eac2..4959ecee0c21c 100644
--- a/drivers/net/ethernet/intel/ice/ice_vf_lib.h
+++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.h
@@ -19,7 +19,8 @@
 #define ICE_MAX_SRIOV_VFS		256
 
 /* VF resource constraints */
-#define ICE_MAX_RSS_QS_PER_VF	16
+/* for "old" virtchnl opcodes that accept up to 16 queues */
+#define ICE_MAX_QS_PER_VF_VCV1	16
[Severity: Low]
This isn't a bug, but the new comment calls this constant a limit for the
"old" virtchnl opcodes. At this point in the series, several of its users
are not opcode limits.

The txq_ena/rxq_ena bitmaps and qs_bw[] in struct ice_vf, and q_home[][]
in struct ice_lag, use it as a storage size. ice_set_per_vf_res() uses it
as the per-VF Tx/Rx queue cap. ice_vsi_set_rss_params() uses it as the VF
VSI rss_size.

The value is still 16 everywhere, so nothing goes out of bounds here. The
next patch in the series ("ice: bump to 256qs for VF") adds
ICE_MAX_QS_PER_VF and moves the storage, allocation and RSS users over to
it. After that, ICE_MAX_QS_PER_VF_VCV1 remains only at the v1 opcode
sites.

Could ICE_MAX_QS_PER_VF be introduced in this patch, with only the opcode
sites switched to the VCV1 name? That way the intermediate tree would
match the new comment.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261117094913.100756-1-przemyslaw.kitszel%40intel.com
Thread (25 messages) 25 messages, 2 authors, last reply 13h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help