Re: [PATCH net-next v2 3/4] net: phy: marvell: factor out EEE errata initialization

From
Andrew Lunn <andrew@lunn.ch>
Date
2026-11-17 02:04:28
Also in
lkml
Reply to
Paul Louvel, 2026-11-16
On Mon, Nov 16, 2026 at 04:27:03PM +0100, Paul Louvel wrote:
The 88E151x EEE errata sequence writes four register pairs on page 0xFF.
Using phy_write() for each access takes and releases the MDIO bus lock
every time, and returning early on error leaves the PHY on the errata
page.

Move the sequence into m88e1510_eee_errata() and use phy_select_page()
and phy_restore_page().
This reduces the number of bus lock/unlock cycles and restores the
previous page if one of the errata writes fails.

Signed-off-by: Paul Louvel (Schneider Electric) <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Thread (11 messages) 11 messages, 4 authors, last reply 4h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help