Thread (4 messages) 4 messages, 4 authors, 1h ago

[PATCH] net: dsa: loop: release netdev reference on registration failure

flat view
HOTtoday

From: Wentao Liang <hidden>
Date: 2026-11-03 10:05:27
Also in: lkml, stable
Subsystem: networking drivers, networking [dsa], the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn, Vladimir Oltean, Linus Torvalds

dsa_loop_drv_probe() takes a reference on the CPU net_device with
dev_get_by_name() before calling dsa_register_switch(). The matching
dev_put() is only done in dsa_loop_drv_remove(), which the driver core
does not call after a failed probe, so every failed registration leaks
the reference.

Drop the reference when dsa_register_switch() fails.

Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
Cc: <redacted>
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <redacted>
---
 drivers/net/dsa/dsa_loop.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index 0e35e9841b9b..fd02327b5a56 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -390,6 +390,8 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)
 	if (!ret)
 		dev_info(&mdiodev->dev, "%s: 0x%0x\n",
 			 pdata->name, pdata->enabled_ports);
+	else
+		dev_put(ps->netdev);
 
 	return ret;
 }
-- 
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help