Thread (2 messages) 2 messages, 2 authors, 17d ago

[PATCH] net: dsa: dsa_loop: Fix netdev leak in dsa_loop_drv_probe()

COLD17d

From: Wentao Liang <hidden>
Date: 2026-09-17 10:46:35
Also in: lkml, stable
Subsystem: networking drivers, networking [dsa], the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn, Vladimir Oltean, Linus Torvalds

In dsa_loop_drv_probe(), a reference to the configured network device
is taken with dev_get_by_name().  This reference is dropped in
dsa_loop_drv_remove() on success, but if dsa_register_switch() fails,
the probe returns without releasing it, leaking the reference.

Fix this by dropping the reference with dev_put() when
dsa_register_switch() fails.

Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <redacted>
---
 drivers/net/dsa/dsa_loop.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index 7058faf23592..b6b6fcffb406 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -389,6 +389,8 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)
 	if (!ret)
 		dev_info(&mdiodev->dev, "%s: 0x%0x\n",
 			 pdata->name, pdata->enabled_ports);
+	else
+		dev_put(ps->netdev);
 
 	return ret;
 }
-- 
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help