Re: [PATCH net-next v2 2/5] net: phy: mxl-gpy: add MxL86211C VDDP supply
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-10-16 21:12:49
Also in:
linux-devicetree, lkml
quoted hunk ↗ jump to hunk
+static int mxl86211c_probe(struct phy_device *phydev) +{ + struct device *dev = &phydev->mdio.dev; + struct gpy_priv *priv; + struct regulator *vddp; + int ret; + + vddp = devm_regulator_get(dev, "vddp"); + if (IS_ERR(vddp)) + return dev_err_probe(dev, PTR_ERR(vddp), + "failed to get VDDP supply\n"); + if (!vddp) + return dev_err_probe(dev, -EOPNOTSUPP, + "VDDP supply requires regulator support\n"); +
quoted hunk ↗ jump to hunk
static bool gpy_sgmii_need_reaneg(struct phy_device *phydev) { struct gpy_priv *priv = phydev->priv;@@ -1406,7 +1467,7 @@ static struct phy_driver gpy_drivers[] = { .name = "Maxlinear Ethernet MxL86211C", .get_features = genphy_c45_pma_read_abilities, .config_init = gpy21x_config_init, - .probe = gpy_probe, + .probe = mxl86211c_probe,
This is an existing device. You cannot add required new DT parameters,
that would break backwards compatibility. Anything you add news to be
optional.
Andrew
---
pw-bot: cr