Re: [PATCH net-next 2/4] dt-bindings: net: qcom,ipq9574-ppe: Tighten ethernet port node constraints
flat view
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-10-09 08:36:14
Also in:
linux-arm-msm, linux-devicetree, linux-doc, lkml
On Mon, Oct 05, 2026 at 05:29:13PM +0200, Til Kaiser wrote:
The port node pattern "^ethernet-port@[1-6]+$" also matches multi-digit unit addresses such as ethernet-port@11, which the reg property does not allow. Drop the stray '+'. Also restrict the ethernet-ports object to its declared properties. Without this, nodes outside the port pattern are accepted through the generic ethernet-switch schema.
Simple test shows that it is not true, so I do not get how you reproduced it. Are you sending some LLM output?
quoted hunk ↗ jump to hunk
Signed-off-by: Til Kaiser <redacted> --- .../devicetree/bindings/net/qcom,ipq9574-ppe.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml b/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml index 6d0b21a10732..1a78e2c82b90 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml@@ -174,8 +174,17 @@ properties: - interrupt-names ethernet-ports: + type: object + additionalProperties: false + + properties: + '#address-cells': + const: 1 + '#size-cells': + const: 0
No need for any of these. Best regards, Krzysztof