Re: [PATCH net-next 4/4] net: macb: Clear SRTSM outside PTPv2 receive filters
flat view
From: Théo Lebrun <theo.lebrun@bootlin.com>
Date: 2026-09-22 19:27:46
Also in:
lkml
Hello Kim, On Tue Sep 22, 2026 at 11:10 AM CEST, Kim Wooseok via B4 Relay wrote:
From: Kim Wooseok <redacted> A PTPv2 receive filter sets NCR.SRTSM, but switching to NONE, ALL or a PTPv1 filter leaves it set. As a result, selecting the same filter can produce a different register setting depending on whether PTPv2 was used before. Update SRTSM whenever the RX filter changes, setting it only for PTPv2. Switching away from PTPv2 then clears the old setting, so the bit follows the currently selected filter. Assisted-by: GPT-6 Astra Signed-off-by: Kim Wooseok <redacted>
This one sounds more relevant to keep (compared to patch 3). We have NCFGR.DRFCS always set so the FCS is always discarded so I don't think we fix any bug here. But we avoid a footgun that could hit later if we add Rx FCS support. Reviewed-by: Théo Lebrun <theo.lebrun@bootlin.com> Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com