Re: [PATCH net-next 3/4] net: macb: Disable one-step mode when TX timestamping is off
flat view
From: Théo Lebrun <theo.lebrun@bootlin.com>
Date: 2026-09-22 19:16:01
Also in:
lkml
Hello Kim, On Tue Sep 22, 2026 at 11:10 AM CEST, Kim Wooseok via B4 Relay wrote:
From: Kim Wooseok <redacted>
Switching from HWTSTAMP_TX_ONESTEP_SYNC to HWTSTAMP_TX_OFF turns off
descriptor timestamping, but leaves NCR.OSSMODE set, so one-step mode
remains enabled.
Update OSSMODE for every accepted TX mode and set it only for
HWTSTAMP_TX_ONESTEP_SYNC. This also clears the previous one-step setting
when switching to OFF. Since the update mask now always includes
OSSMODE, drop the check for an empty mask.
Fixes: ab91f0a9b5f4 ("net: macb: Add hardware PTP support")
Assisted-by: GPT-6 Astra
Signed-off-by: Kim Wooseok <redacted>I don't see the point in this commit. NCR.OSSMODE defines what value we put in TX Sync messages. This register can be left alone when HWTSTAMP_TX_OFF. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com