Thread (21 messages) flat view 21 messages, 4 authors, 4d ago

Re: [PATCH net-next v3 5/8] net: dsa: motorcomm: Introduce yt921x_speed

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-09-22 11:53:27
Also in: lkml

+	if (ps == YT921X_SPEED_NUM)
 		return -EINVAL;
-	}
+enum yt921x_speed {
+	YT921X_SPEED_10,
+	YT921X_SPEED_100,
+	YT921X_SPEED_1000,
+	YT921X_SPEED_10000,
+	YT921X_SPEED_2500,
+	YT921X_SPEED_NUM
+};
A nitpick, but i think YT921X_SPEED_NUM could be better named, like
YT921X_SPEED_INVALID.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help