Re: [PATCH net-next] net: phy: mediatek: do not match MT7530 PHY if 10/100 only
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-09-18 16:59:11
Also in:
linux-arm-kernel, linux-mediatek, lkml
On Fri, Sep 18, 2026 at 06:47:02PM +0200, Caleb James DeLisle wrote:
On 18/09/2026 18:29, Andrew Lunn wrote:quoted
On Fri, Sep 18, 2026 at 04:11:56PM +0000, Caleb James DeLisle wrote:quoted
An EcoNet SoC 10/100 PHY uses the same ID as the MT7530 PHY, but a true MT7530 PHY always has gigabit support so they can be distinguished by the presence of the ESTATUS_1000_TFULL flag. Add a match_phy_device which refuses to match if the PHY is not gigabit.Don't you also need the opposite in mtk-fe-soc.c? Otherwise don't you rely on the load order of the PHY drivers?The collision is in econet-fe-soc.c of https://lore.kernel.org/netdev/20260827065930.2618729-3-cjd@cjdns.fr/ (local)
Ah, you have a similar match function there. Good.
And I notice now that I did add it in that patchset as well, but this implementation is better done.
Yes, the one here is nicer. It would be good to use the same idea in
the econet-fe-soc.c.
Andrew