[PATCH net-next] net: phy: mediatek: do not match MT7530 PHY if 10/100 only
From: Caleb James DeLisle <cjd@cjdns.fr>
Date: 2026-09-18 16:12:29
Also in:
linux-arm-kernel, linux-mediatek, lkml
Subsystem:
ethernet phy library, mediatek ethernet phy drivers, networking drivers, the rest · Maintainers:
Andrew Lunn, Heiner Kallweit, Daniel Golle, Qingfang Deng, SkyLake Huang, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
An EcoNet SoC 10/100 PHY uses the same ID as the MT7530 PHY, but a true MT7530 PHY always has gigabit support so they can be distinguished by the presence of the ESTATUS_1000_TFULL flag. Add a match_phy_device which refuses to match if the PHY is not gigabit. Signed-off-by: Caleb James DeLisle <cjd@cjdns.fr> --- This supercedes [PATCH v6 net-next] net: phy: mediatek: support MT7530 PHYs on EN71221 MCM Link: https://lore.kernel.org/netdev/20260917130534.297930-1-cjd@cjdns.fr (local) Because after the recent EEE disablement in the driver, it is found that the default MT7530 PHY driver does apparently work with the EcoNet MCM MT7530. --- drivers/net/phy/mediatek/mtk-ge.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/drivers/net/phy/mediatek/mtk-ge.c b/drivers/net/phy/mediatek/mtk-ge.c
index 96d8ac5154e5..f801966bb4ee 100644
--- a/drivers/net/phy/mediatek/mtk-ge.c
+++ b/drivers/net/phy/mediatek/mtk-ge.c@@ -101,6 +101,18 @@ static int mt7530_phy_config_init(struct phy_device *phydev) return 0; } +/* + * MTK_GPHY_ID_MT7530 ID is also used for an EcoNet SoC FE phy, but that PHY + * does not advertise ESTATUS_1000_TFULL. Match this driver only if the PHY + * advertizes gigabit capability. + */ +static int mt753x_gphy_match(struct phy_device *phydev, + const struct phy_driver *phydrv) +{ + return genphy_match_phy_device(phydev, phydrv) && + (phy_read(phydev, MII_ESTATUS) & ESTATUS_1000_TFULL) != 0; +} + static int mt7531_phy_config_init(struct phy_device *phydev) { mtk_gephy_config_init(phydev);
@@ -135,6 +147,7 @@ static struct phy_driver mtk_gephy_driver[] = { */ .config_intr = genphy_no_config_intr, .handle_interrupt = genphy_handle_interrupt_no_ack, + .match_phy_device = mt753x_gphy_match, .suspend = genphy_suspend, .resume = genphy_resume, .read_page = mtk_phy_read_page,
--
2.39.5