Thread (29 messages) flat view 29 messages, 3 authors, 1d ago

Re: [PATCH net 7/8] net: bcmgenet: zero-initialize Transmit Status Block in bcmgenet_add_tsb

From: Nicolai Buchwitz <hidden>
Date: 2026-09-18 11:03:29
Also in: lkml

Hi Florian

On 18.9.2026 02:07, Florian Fainelli wrote:
bcmgenet_add_tsb() pushes 64 bytes of headroom onto the skb to form the
Transmit Status Block (TSB) but only assigns status->tx_csum_info when
skb->ip_summed == CHECKSUM_PARTIAL. For packets without checksum 
offload,
or for other fields within struct status_64, the status block contains
uninitialized stack/heap memory from previous skb operations.
The MAC only reads tx_csum_info when the descriptor has DMA_TX_DO_CSUM,
and bcmgenet_xmit() sets that only for CHECKSUM_PARTIAL.
The stale value seems to be never used?

Did you hit an actual failure?  Otherwise this would be a 64 byte memset
on every transmitted packet.
[...]
Thanks,
Nicolai
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help