Re: [PATCH net 3/8] net: bcmgenet: do not skip WoL power up on GENET V1

On 18.9.2026 02:07, Florian Fainelli wrote:

bcmgenet_power_up() had an early check for bcmgenet_has_ext(priv) before
dispatching by power mode. GENET V1 does not have the EXT block (unlike
GENET V2+), which causes bcmgenet_power_up() to immediately return 0.

As a consequence, when waking up from GENET_POWER_WOL_MAGIC on GENET V1,
bcmgenet_wol_power_up_cfg() is never invoked to disable the WoL clock,
clear wake event masks, and restore normal PHY and MAC operations.

Move the bcmgenet_has_ext() checks to the GENET_POWER_PASSIVE and
GENET_POWER_CABLE_SENSE cases where the EXT registers are actually
accessed, allowing GENET_POWER_WOL_MAGIC cleanup to execute on all
hardware versions.

Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")

c3ae64ae0c08 ("net: bcmgenet: handle GENET_POWER_WOL_MAGIC") ?

[...]

With the correct Fixes tag:

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>

Thanks,
Nicolai