Re: [PATCH net-next 05/10] netlink: specs: devlink: fix resource-scope type
From: Moshe Shemesh <hidden>
Date: 2026-09-17 14:36:31
Also in:
lkml
On 9/12/2026 12:41 AM, Asbjørn Sloth Tønnesen wrote:
The correct type for resource-scope is flags, not enum: - DEVLINK_RESOURCE_SCOPE_DEV is _BITUL(0) aka. 1, not 0. - DEVLINK_RESOURCE_SCOPE_PORT is _BITUL(1) aka. 2, not 1.
Note that once the resource-scope is defined as flags, the "enum-as-flags: true" on resource-scope-mask is redundant - please drop it. With that: Reviewed-by: Moshe Shemesh <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Asbjørn Sloth Tønnesen <redacted> CC: Cosmin Ratiu <redacted> CC: Jiri Pirko <jiri@resnulli.us> CC: Moshe Shemesh <redacted> CC: Or Har-Toov <redacted> CC: Tariq Toukan <tariqt@nvidia.com> --- Documentation/netlink/specs/devlink.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml index 38b1190f3d26..0b3160e201da 100644 --- a/Documentation/netlink/specs/devlink.yaml +++ b/Documentation/netlink/specs/devlink.yaml@@ -158,7 +158,7 @@ definitions: - name: entry - - type: enum + type: flags name: resource-scope entries: - --2.55.0