Re: [PATCH net-next 1/3] r8169: propagate errors from PHY write operations

On 2026-09-16 18:14, Andrew Lunn Wrote:

On Wed, Sep 16, 2026 at 06:10:00PM -0300, Matheus Alves de Almeida wrote:

quoted

quoted

Maybe rewrite rtl_loop_wait_low(), _high() and rtl_loop_wait() to use
iopoll.h?

While I don’t think this fits the scope of this series, I’d be willing
to look into it as a follow-up.

You trimmed too much context.

The nice thing about iopoll.h is that they all return -ETIMEDOUT, or
some other error code on error. So your current patch looking at the
Boolean return value becomes redundant, you just follow the normal
pattern:

       ret = rtl_loop_wait_low();
       if (ret)
       	  return ret;

So i think this is in scope, otherwise you are going to rewrite 90% of
this patch when you do introduce it.

     Andrew

Sorry about trimming too much context. That makes sense. I was thinking
of the iopoll.h conversion primarily as cleanup. I’ll rework this for v2.