Re: [PATCH net-next 1/3] r8169: propagate errors from PHY write operations
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-09-16 18:39:21
Also in:
lkml
-static void r8168_phy_ocp_write(struct rtl8169_private *tp, u32 reg, u32 data)
+static int r8168_phy_ocp_write(struct rtl8169_private *tp, u32 reg, u32 data)
{
if (rtl_ocp_reg_failure(reg))
- return;
+ return 0;
RTL_W32(tp, GPHY_OCP, OCPAR_FLAG | (reg << 15) | data);
- rtl_loop_wait_low(tp, &rtl_ocp_gphy_cond, 25, 10);
+ return rtl_loop_wait_low(tp, &rtl_ocp_gphy_cond, 25, 10) ?
+ 0 : -ETIMEDOUT;Maybe rewrite rtl_loop_wait_low(), _high() and rtl_loop_wait() to use iopoll.h? Andrew