Re: [PATCH v2 net 2/4] neighbour: Enforce min/max to NDTPA_INTERVAL_PROBE_TIME_MS.

On Tue, Sep 8, 2026 at 11:56 PM Ido Schimmel [off-list ref] wrote:

On Wed, Sep 09, 2026 at 09:51:16AM +0300, Ido Schimmel wrote:

quoted

On Tue, Sep 08, 2026 at 09:12:46PM +0000, Kuniyuki Iwashima wrote:

quoted

diff --git a/Documentation/netlink/specs/rt-neigh.yaml b/Documentation/netlink/specs/rt-neigh.yaml
index 0f46ef313590..5ec57d95d7f6 100644
--- a/Documentation/netlink/specs/rt-neigh.yaml
+++ b/Documentation/netlink/specs/rt-neigh.yaml

@@ -341,6 +341,8 @@ attribute-sets:
       -
         name: interval-probe-time-ms
         type: u64
+        min: 1
+        max: 86400000

This differs from what I suggested [1] and fails validation:

Oh sorry, I completely overlooked "check:" !

quoted

$ tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/rt-neigh.yaml \
      --schema Documentation/netlink/netlink-raw.yaml --validate

TIL : --validate

I was wondering how it could be used after seeing strace
showed recvmsg() with -ERANGE from kernel.

quoted

[...]
jsonschema.exceptions.ValidationError: Additional properties are not allowed ('max', 'min' were unexpected)
[...]
On instance['attribute-sets'][2]['attributes'][18]:
    {'name': 'interval-probe-time-ms',
     'type': 'u64',
     'min': 1,
     'max': 86400000}

Works fine with this diff [2]:

$ tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/rt-neigh.yaml \
      --schema Documentation/netlink/netlink-raw.yaml --validate
$ echo $?
0

BTW, patch LGTM otherwise, so you can add my tag to v3. Thanks!

Will fix "check:" in v3 and add your tag.

Thank you !