Re: [PATCH v2 net 2/4] neighbour: Enforce min/max to NDTPA_INTERVAL_PROBE_TIME_MS.
From: Ido Schimmel <idosch@nvidia.com>
Date: 2026-09-09 06:51:28
Subsystem:
networking [general], networking [ipv4/ipv6], the rest, yaml netlink (ynl) · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern, Ido Schimmel, Linus Torvalds, Donald Hunter
On Tue, Sep 08, 2026 at 09:12:46PM +0000, Kuniyuki Iwashima wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/netlink/specs/rt-neigh.yaml b/Documentation/netlink/specs/rt-neigh.yaml index 0f46ef313590..5ec57d95d7f6 100644 --- a/Documentation/netlink/specs/rt-neigh.yaml +++ b/Documentation/netlink/specs/rt-neigh.yaml@@ -341,6 +341,8 @@ attribute-sets: - name: interval-probe-time-ms type: u64 + min: 1 + max: 86400000
This differs from what I suggested [1] and fails validation:
$ tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/rt-neigh.yaml \
--schema Documentation/netlink/netlink-raw.yaml --validate
[...]
jsonschema.exceptions.ValidationError: Additional properties are not allowed ('max', 'min' were unexpected)
[...]
On instance['attribute-sets'][2]['attributes'][18]:
{'name': 'interval-probe-time-ms',
'type': 'u64',
'min': 1,
'max': 86400000}
Works fine with this diff [2]:
$ tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/rt-neigh.yaml \
--schema Documentation/netlink/netlink-raw.yaml --validate
$ echo $?
0
[1] https://lore.kernel.org/netdev/20260908100548.GB903218@shredder/ (local)
[2]diff --git a/Documentation/netlink/specs/rt-neigh.yaml b/Documentation/netlink/specs/rt-neigh.yaml
index 5ec57d95d7f6..c8e55c98d564 100644
--- a/Documentation/netlink/specs/rt-neigh.yaml
+++ b/Documentation/netlink/specs/rt-neigh.yaml@@ -341,8 +341,9 @@ attribute-sets: - name: interval-probe-time-ms type: u64 - min: 1 - max: 86400000 + checks: + min: 1 + max: 86400000 operations: enum-model: directional