Thread (3 messages) 3 messages, 3 authors, 2026-09-09

Re: [PATCH iwl] eth: ice: don't dereference pointers from TP_printk()

flat view

From: Breno Leitao <leitao@debian.org>
Date: 2026-09-09 14:16:28
Also in: intel-wired-lan

On Thu, Aug 20, 2026 at 07:02:01PM -0700, Jakub Kicinski wrote:
After forwarding net-next during the v7.3 merge window we started
seeing:

  TRACE EVENT ERROR: Event ice_tx_dim_work has double dereference in TP_printk: REC->q_vector->tx.tx_ring->q_index
  WARNING: kernel/trace/trace_events.c:420 at test_double_dereference.cold+0x39/0x4b
I am seeing this in one of my hosts as well.
this is due to extra checks added in tracing subsystem in
commit b5cc230af5e5 ("tracing: Warn when an event dereferences a pointer in TP_printk()").

Printing happens long after the event was recorded, by which point
the pointers may be invalid (the ring or the dim instance).
Copy the eight scalars into the event instead.

Fixes: 3089cf6d3caa ("ice: add tracepoints")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help