RE: [PATCH iwl] eth: ice: don't dereference pointers from TP_printk()

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org> 
Sent: Thursday, August 20, 2026 7:02 PM
To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
Cc: netdev@vger.kernel.org; davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; andrew+netdev@lunn.ch; horms@kernel.org; intel-wired-lan@lists.osuosl.org; Jakub Kicinski <kuba@kernel.org>; Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; jbrandeb@kernel.org; Shelton, > Benjamin H <redacted>
Subject: [PATCH iwl] eth: ice: don't dereference pointers from TP_printk()

After forwarding net-next during the v7.3 merge window we started
seeing:

  TRACE EVENT ERROR: Event ice_tx_dim_work has double dereference in TP_printk: REC->q_vector->tx.tx_ring->q_index
  WARNING: kernel/trace/trace_events.c:420 at test_double_dereference.cold+0x39/0x4b

this is due to extra checks added in tracing subsystem in commit b5cc230af5e5 ("tracing: Warn when an > event dereferences a pointer in TP_printk()").

Printing happens long after the event was recorded, by which point the pointers may be invalid (the ring > or the dim instance).
Copy the eight scalars into the event instead.

Fixes: 3089cf6d3caa ("ice: add tracepoints")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: anthony.l.nguyen@intel.com
CC: przemyslaw.kitszel@intel.com
CC: jbrandeb@kernel.org
CC: benjamin.h.shelton@intel.com
---
 drivers/net/ethernet/intel/ice/ice_trace.h | 64 ++++++++++++++--------
 1 file changed, 42 insertions(+), 22 deletions(-)

Tested-by: Alexander Nowlin <redacted>