Re: [PATCH net-next v2 2/2] net: dsa: realtek: rtl8365mb: add EEE support

On Thu, Sep 3, 2026 at 11:22 AM Oleksij Rempel [off-list ref] wrote:

Add EEE support on the integrated-PHY ports, controllable per port via
ethtool.

The integrated PHYs have no MMD registers; their EEE registers live in the
switch's OCP space. phylib accesses EEE as MMD registers, so add
phy_{read,write}_c45 realtek_ops that map those MMD accesses onto their OCP
addresses, wired as the user MII bus C45 handlers when the chip provides
them (rtl8366rb etc. unaffected).

The hardware manages LPI on its own, so advertise EEE to phylink with
no-op mac_{en,dis}able_tx_lpi callbacks. The LPI timer is a single global
per-speed register, so .set_mac_eee rejects the per-port TX LPI knobs
rather than silently ignoring them.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Excellent work on this Oleksij!
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij