Re: [PATCH] Add config phase for dp83td510e phy

On Wed, Sep 02, 2026 at 03:52:58PM +0000, Julien Blanc wrote:

Add a config phase for the Texas Instruments DP83TD510E ethenet PHY

The config phase currently sets the following properties from the
device tree:
  * RMII / RGMII mode (note : RMII master / slave can only be set
    by straps and cannot be changed at runtime on this phy)
  * RGMII delays. These delays can be enabled on the phy side, only
    as a boolean. Delays are enabled if phy-mode is rgmii-id, or
    rgmii-[rx|tx]id which enables only the corresponding delay.

+static int dp83td510_config_init(struct phy_device *phydev)
+{
+	struct device *dev = &phydev->mdio.dev;
+	int rgmii_delay = 0;
+	s32 rx_int_delay;
+	s32 tx_int_delay;
+	int ret;
+
+	if (phy_interface_is_rgmii(phydev)) {
+		rx_int_delay = phy_get_internal_delay(phydev, dev, NULL, 0,
+						      true);
+

If delays are simple on/off, you don't need this. Do something more
like mxl86110_config_rgmii_delay() which just look at
phydev->interface.

    Andrew

---
pw-bot: cr