回覆: [PATCH v2 net-next] net: phy: air_en8811h: select LED GPIO pins based on AN8811HB package variant

(Resending in plain text, apologies for the duplicate.)

Hi Andrew,

Yes, I've seen Ziyou's patch, which is now at v3
(https://lore.kernel.org/netdev/20260829033844.1975-1-xuziyougm@gmail.com/ (local)).

My patch is a superset of Ziyou's: it also restores the GPIO output
pins in config_init, but additionally selects the correct set of GPIO
pins based on the AN8811HB package variant (HBCN uses GPIOs 0, 1, 15;
HBN uses GPIOs 3, 4, 5).

I'll wait for Ziyou's v3 to be merged, then rebase and send v3 of this
patch on top of it.

Thanks,
Weiting


________________________________________
寄件者: Andrew Lunn [off-list ref]
已傳送: 星期五, 2026 年 8 月 28 日  下午 09:07
收件者: WeiTing Lee (李威霆) [off-list ref]
副本: netdev@vger.kernel.org [off-list ref]; hkallweit1@gmail.com [off-list ref]; linux@armlinux.org.uk [off-list ref]; davem@davemloft.net [off-list ref]; kuba@kernel.org [off-list ref]; edumazet@google.com [off-list ref]; pabeni@redhat.com [off-list ref]; linux-kernel@vger.kernel.org [off-list ref]; bjorn@mork.no [off-list ref]; ericwouds@gmail.com [off-list ref]; frank-w@public-files.de [off-list ref]; Joseph Lin (林蔚煌) [off-list ref]; Wenshin Chung (鍾問星) [off-list ref]; Lucien Jheng (鄭祥鈞) [off-list ref]; Albert-AL Lee (李家宏) [off-list ref]
主旨: Re: [PATCH v2 net-next] net: phy: air_en8811h: select LED GPIO pins based on AN8811HB package variant


On Fri, Aug 28, 2026 at 01:05:36PM +0800, Weiting Lee wrote:

The AN8811HB comes in two package variants, AN8811HBCN and AN8811HBN,

which use different GPIO pins to drive LED outputs. AN8811HBCN uses

GPIOs 0, 1, and 15, while AN8811HBN uses GPIOs 3, 4, and 5. Using a

fixed GPIO assignment causes incorrect LED behavior on one of the

variants.

Read the package variant from the read-only silicon identification bits

in AN8811HB_HWTRAP2 at probe time and store it in priv->is_an8811hbcn.

Add an8811hb_led_gpio_setup() to configure the correct GPIO output pins

and select lines based on the detected variant, and call it from

config_init.

Have yo seen the patch:



Ziyou Xu [PATCH net v2] net: phy: air_en8811h: restore AN8811HB LED GPIO after MCU



There is likely to be a merge conflict with it. We probably should get

that patch merged first.



     Andrew