[PATCH v5 11/12] platform/x86: ideapad-laptop: Serialize keyboard backlight notifications
From: Rong Zhang <hidden>
Date: 2026-08-20 17:26:45
Also in:
chrome-platform, linux-doc, linux-leds, lkml, platform-driver-x86
Subsystem:
ideapad laptop extras driver, lenovo drivers, the rest, x86 platform drivers · Maintainers:
Ike Panhc, Mark Pearson, Derek J. Clark, Linus Torvalds, Hans de Goede, Ilpo Järvinen
ACPI notifications are delivered in dedicated work contexts and may arrive simultaneously. In the following change, much work will be done while handling the notification, which could lead to potential race conditions. Introduce a new mutex to serialize keyboard backlight notifications to prevent potential race conditions. Acked-by: Ike Panhc <ikepanhc@gmail.com> Signed-off-by: Rong Zhang <redacted> --- Changes in v4: - Remove needless #include (Thanks Ilpo Järvinen) --- drivers/platform/x86/lenovo/ideapad-laptop.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/lenovo/ideapad-laptop.c b/drivers/platform/x86/lenovo/ideapad-laptop.c
index 2fa2665f35d6..7f7b1e30c326 100644
--- a/drivers/platform/x86/lenovo/ideapad-laptop.c
+++ b/drivers/platform/x86/lenovo/ideapad-laptop.c@@ -29,6 +29,7 @@ #include <linux/kernel.h> #include <linux/leds.h> #include <linux/module.h> +#include <linux/mutex.h> #include <linux/platform_device.h> #include <linux/platform_profile.h> #include <linux/power_supply.h>
@@ -230,6 +231,8 @@ struct ideapad_private { int type; struct led_classdev led; atomic_t last_hw_brightness; + + struct mutex notif_mutex; /* protects notifications */ } kbd_bl; struct { bool initialized;
@@ -1722,6 +1725,8 @@ static void ideapad_kbd_bl_notify(struct ideapad_private *priv) if (!priv->kbd_bl.initialized) return; + guard(mutex)(&priv->kbd_bl.notif_mutex); + hw_brightness = ideapad_kbd_bl_hw_brightness_get(priv); if (hw_brightness < 0) return;
@@ -1747,6 +1752,10 @@ static int ideapad_kbd_bl_init(struct ideapad_private *priv) if (WARN_ON(priv->kbd_bl.initialized)) return -EEXIST; + err = devm_mutex_init(&priv->platform_device->dev, &priv->kbd_bl.notif_mutex); + if (err) + return err; + hw_brightness = ideapad_kbd_bl_hw_brightness_get(priv); if (hw_brightness < 0) return hw_brightness;
--
2.55.0