Re: [PATCH net-next v2] net: phy: motorcomm: enable the reference clock for YT8521 and YT8531

On Tue, Jul 28, 2026 at 09:57:32PM +0800, Gavin Gao wrote:

Hi Alexey,

I slightly prefer keeping the helper.

This looks like a common pattern for the Motorcomm family rather than a
YT8521/YT8531-specific detail. Other PHYs in the same series may need the
same optional reference clock handling later, and a small helper keeps
that path easy to reuse without duplicating the same code.

Please don't top post.

Look around at other drivers. Is it generally put into a tiny helper,
or used inline?

My gut feeling from reviewing lots of drivers is that it is inline.

    Andrew

---
pw-bot: cr