Re: [PATCH net-next v2 0/2] net: macb: Updated patches for 1000BASE-X support

On Tue, Jul 21, 2026 at 01:56:00PM -0400, Nathan Whitehorn wrote:

This series adds support for 1000BASE-X autonegotiation to the Cadence macb driver
when using the MAC-internal PCS. The existing driver code is oriented toward the PCS
being used with an on-board SGMII PHY, so uses Cisco SGMII-style autonegotiation
exclusively and does not anticipate e.g. link state changes arising from fiber
attach/detach events. The first patch changes the driver to monitor the PCS's
link; the second extends the existing SGMII autonegotiation code to also support
1000BASE-X autonegotiation.

Your first version of the patch mentioned that this was tested on a
Polarfire SoC. This is some useful info that you can put in the cover
letter. I'd also be interested in knowing if you tested with a copper or
fiber SFP.

Also you shouldn't post newer versions of a patch set as a reply to the
previous version.

Thanks,
Charles