Re: [PATCH net-next v2 2/2] net: macb: add support for 1000BASE-X autonegotiation to PCS

On Tue, Jul 21, 2026 at 01:56:02PM -0400, Nathan Whitehorn wrote:

The current PCS code unconditionally uses SGMII autonegotiation, though
the hardware supports both SGMII and 1000BASE-X modes. Decouple the
choice of PCS enablement from use of the SGMII mode when running at
gigabit rates and announce to phylink that 1000BASE-X is a supported
operating mode. This enables direct attachment of the PCS to e.g. an
SFP.

The 1000BASE-X code in phylink also sometimes calls the autonegotiation
restart method, so add an implementation of autonegotiation restart.

Signed-off-by: Nathan Whitehorn <redacted>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew