Thread (15 messages) 15 messages, 2 authors, 4d ago

Re: [PATCH net-next v3 04/12] net: mctp: usb: Improve IN endpoint status handling

From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2026-07-09 03:12:52
Also in: linux-usb

Hi Oliver,
Thanks for taking a look.


What allows the assumption that mctp_usb_open() does not race
with error handling? What happens if the device is still stalled?
When ndo_open is called, we know that the delayed rx work (which
performs the usb_clear_halt) has been quiesced, so aren't racing with
the actual recovery.

The device may still be stalled; that should be okay though, as we'll
detect that through the subsequent IN urb submission, which will re-set
->clear halt and schedule the rx work to do the clear.

Unless I have missed a case there?

Cheers,


Jeremy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help