Thread (15 messages) 15 messages, 2 authors, 4d ago

Re: [PATCH net-next v3 04/12] net: mctp: usb: Improve IN endpoint status handling

From: Oliver Neukum <oneukum@suse.com>
Date: 2026-07-08 12:57:45
Also in: linux-usb

On 08.07.26 11:58, Jeremy Kerr wrote:

Hi,
quoted hunk ↗ jump to hunk
@@ -198,6 +254,8 @@ static int mctp_usb_open(struct net_device *dev)
  	struct mctp_usb *mctp_usb = netdev_priv(dev);
  
  	WRITE_ONCE(mctp_usb->rx_stopped, false);
+	mctp_usb->clear_halt = false;
+	mctp_usb->in_err_count = 0;
What allows the assumption that mctp_usb_open() does not race
with error handling? What happens if the device is still stalled?
It seems to me that you need to wait for the halt to be cleared.

	Regards
		Oliver
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help