Thread (27 messages) 27 messages, 4 authors, 16d ago

Re: [PATCH 3/9] ax88179_178a: Add support for AX88179A MMD access

From: Birger Koblitz <hidden>
Date: 2026-07-08 18:33:17
Also in: linux-usb, lkml

Thanks Maxime for reviewing this patch!

On 7/1/26 11:53, Maxime Chevallier wrote:
ADVERTISE_RESV isn't an unknown bit, it's been added in 802.3 as ADVERTISE_XNP
for Extended Next Page, see :

commit e7a62edd34b1 ("net: phy: qcom: at803x: Use the correct bit to disable extended next page")

we shoudln't use ADVERTISE_RESV anymore in-kernel (there are a few callsites left).

As this seems to be a vendor-specific behaviour for that bit, please add a
local #define for it in this driver, to make it clear that this is a device-specific
value.
Will fix as suggested in v2 call it AX_ADVERTISE_2500.
And btw, I have to mention that I used the cross-referencing of bootlin
a lot for writing this patch-series, and it was enormously helpful. Thanks for that tool!

Birger
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help