Re: [PATCH 2/9] ax88179_178a: Add HW support for AX179A-based chips
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-07-01 15:05:47
Also in:
linux-usb, lkml
#include <linux/usb/usbnet.h> #include <uapi/linux/mdio.h> #include <linux/mdio.h> +#include <linux/if_vlan.h>
Does this patch require this header?
quoted hunk ↗ jump to hunk
@@ -414,7 +570,6 @@ static int ax88179_suspend(struct usb_interface *intf, pm_message_t message) usbnet_suspend(intf, message); - /* Enable WoL */ if (priv->wolopts) {
Please try to avoid changes like this.
/* Force bulk-in zero length */ ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_PHYPWR_RSTCTL, - 2, 2, &tmp16); + 2, 2, &tmp16); tmp16 |= AX_PHYPWR_RSTCTL_BZ | AX_PHYPWR_RSTCTL_IPRL; ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PHYPWR_RSTCTL, - 2, 2, &tmp16); + 2, 2, &tmp16);
Please put white space changes in another patch.
+ /* Initialize MII structure */ + dev->mii.dev = dev->net; + dev->mii.mdio_read = ax88179_mdio_read; + dev->mii.mdio_write = ax88179_mdio_write; + dev->mii.phy_id_mask = 0xff; + dev->mii.reg_num_mask = 0xff; + dev->mii.phy_id = 0x03;
If this device is going to have a long term future, it really should move to phylink. Andrew