Thread (13 messages) 13 messages, 5 authors, 2d ago

Re: [PATCH net-next 2/2] net: phy: qt2025: Use vertical import style

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-07-06 15:51:17
Also in: lkml, rust-for-linux

This is one of the quirks of rustfmt. Before style edition 2024, if an
identifier is all caps, it sorts it after non-all-caps identifiers. The
motivation was to ensure constants are ordered after types, however for things
like C45 it is actually a type, causing this weirdness.
How often does the style edition change? Is there a 2026? How much
changes in each one?

At least in netdev, we tend to reject checkpatch.pl patches, which are
mostly about style, unless they are part of a patchset adding new
features. Style patches are mostly a waste of reviewer/maintainer
time, because some actually break stuff, so need to be reviewed just
as much as code adding new features. But style changes have a low ROI.

So while there is currently not much rust code in the kernel, making
style changes is not wasting too much reviewer/maintainer time, but as
the amount of rust code goes up, you might see some subsystems
rejecting such changes, or wanting to pin to a specific style edition,
to reduce churn.

     Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help