On Mon Jul 6, 2026 at 2:58 PM BST, Andrew Lunn wrote:

On Sun, Jul 05, 2026 at 10:38:41PM -0700, Guru Das Srinagesh wrote:

quoted

Convert `use` imports to vertical layout for better readability and
maintainability.

Signed-off-by: Guru Das Srinagesh <redacted>
---
 drivers/net/phy/qt2025.rs | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
index 470d89a0ac00..efde3f909367 100644
--- a/drivers/net/phy/qt2025.rs
+++ b/drivers/net/phy/qt2025.rs

@@ -14,11 +14,17 @@
 use kernel::io::poll::read_poll_timeout;
 use kernel::net::phy::{
     self,
-    reg::{Mmd, C45},
+    reg::{
+        Mmd,
+        C45, //
+    },

Given the comment this should be sorted in 'ASCIIbetical order',
isn't this wrong, C comes before M? 

	Andrew

This is one of the quirks of rustfmt. Before style edition 2024, if an
identifier is all caps, it sorts it after non-all-caps identifiers. The
motivation was to ensure constants are ordered after types, however for things
like C45 it is actually a type, causing this weirdness.

Miguel, do you think it's worth moving to Rust style edition 2024 before we
switch the lang edition?

Best,
Gary