Re: [PATCH 3/7] cpufreq: rcpufreq_dt: use vertical import style
From: Miguel Ojeda <hidden>
Date: 2026-07-05 12:13:00
Also in:
dri-devel, driver-core, linux-block, linux-pm, linux-pwm, linux-riscv, lkml, nova-gpu, rust-for-linux
On Sun, Jul 5, 2026 at 3:02 AM Guru Das Srinagesh [off-list ref] wrote:
But unfortunately, since `imports_layout` is an unstable option currently [1], it cannot be used straightaway.
Yeah, we are trying to get that one stabilized -- upstream `rustfmt` is aware and working on it. More context at: https://github.com/rust-lang/rustfmt/issues/6829 https://github.com/Rust-for-Linux/linux/issues/398
However, .rustfmt.toml already has a section of commented-out unstable options kept as a reference for when they stabilize. Would it make sense to add `#imports_layout = "Vertical"` there? If so, I can include it in v2.
That may be a bit confusing, because we still need to add the `//` comments. And if you add them, then `rustfmt` will format properly, i.e. you don't need the unstable option. Put another way: the intended workflow is to add the `//` and then to run `make ... rustfmt`. I hope that clarifies! Cheers, Miguel