Re: [PATCH v8 02/14] firmware: qcom_scm: Migrate to generic PAS service

On Fri, Jun 26, 2026 at 06:05:54PM +0100, Julian Braha wrote:

Hi Sumit,

On 6/26/26 14:34, Sumit Garg wrote:

quoted

 config QCOM_SCM
+	tristate "Qualcomm PAS SCM interface driver"
+	select QCOM_PAS
 	select QCOM_TZMEM
-	tristate

I think QCOM_SCM is missing a 'select IRQ_DOMAIN'. Right now I get a
build error without it:

drivers/firmware/qcom/qcom_scm.c: In function ‘qcom_scm_get_waitq_irq’:
  drivers/firmware/qcom/qcom_scm.c:2512:16: error: implicit declaration
of function ‘irq_create_fwspec_mapping’; did you mean
‘irq_create_of_mapping’? [-Wimplicit-function-declaration]
   2512 |         return irq_create_fwspec_mapping(&fwspec);
        |                ^~~~~~~~~~~~~~~~~~~~~~~~~
        |                irq_create_of_mapping

This issue should be independent of this patch-set. Please submit a
standalone fix for this.

-Sumit