Hi Jakub, Andrew,

On 6/28/26 01:46, Andrew Lunn wrote:

On Sat, Jun 27, 2026 at 02:30:28PM -0700, Jakub Kicinski wrote:

quoted

On Sat, 27 Jun 2026 07:34:31 +0200 Maxime Chevallier wrote:

quoted

quoted

This is very far from what existing python tests do in netdev.  

We can probably drop the class, as it is with this discussion, it's merely a way
to regroup doc common to similar tests. The rest really is the usual set of
ksft funcs you can feed to the run function, with a set of ksft_ethtool_*
annotators for generic checks.

The common way of checking prereqs in the tests is to call a function
called require_xyz() which then raises a skip. At a quick glance - the
rss_api and xdp_metadata are good tests to get a sense of the usual format.

The counter example is the ksft_disruptive() decorator.

Pythons own unittest framework makes use of decorators to skip
tests. Its the Pythonic way.

So maybe in the end, we can try to have something a bit less python-y, while still
using extensive documentation using sphynx doc format ?

Let me send a V2 with the full test list, we'll see how much scaffolding
we can build for ethtool testing, and how. I suspect that running/skipping based on
the device's capabilities is going to be used throughout lots of tests
beyond pause.

For now the important part is to get that test list right, and iterate on the
test implementation once we agree on what to test, why and how.

Maxime