Re: [PATCH net-next v5 12/15] onsemi: s2500: Add driver support for TS2500 MAC-PHY
flat view
From: Uwe Kleine-König <hidden>
Date: 2026-06-19 13:59:33
Also in:
linux-devicetree, linux-doc, lkml
On Sun, Jun 14, 2026 at 10:00:28AM -0700, Selvamani Rajagopal via B4 Relay wrote:
quoted hunk ↗ jump to hunk
+static const struct of_device_id s2500_of_match[] = { + { .compatible = "onnn,s2500" }, + {}
s/{}/{ }/
quoted hunk ↗ jump to hunk
+}; + +static const struct spi_device_id s2500_ids[] = { + { "s2500" }, + {} +};
Please make this:
static const struct spi_device_id s2500_ids[] = {
{ .name = "s2500" },
{ }
};
quoted hunk ↗ jump to hunk
+MODULE_DEVICE_TABLE(spi, s2500_ids); + +static struct spi_driver s2500_driver = { + .driver = { + .name = DRV_NAME, + .of_match_table = s2500_of_match, + }, + .probe = s2500_probe, + .remove = s2500_remove, + .id_table = s2500_ids,
Tastes are different, but the idea to align = is usually screwed by follow up patches. Here it's broken from the start. If you ask me: Use a single space before each =.
quoted hunk ↗ jump to hunk
+}; + +module_spi_driver(s2500_driver);
Usually there is no empty line between the driver struct and the macro registering it.
quoted hunk ↗ jump to hunk
+ +MODULE_AUTHOR("Piergiorgio Beruto <pier.beruto@onsemi.com>"); +MODULE_AUTHOR("Selva Rajagopal <selvamani.rajagopal@onsemi.com>"); +MODULE_DESCRIPTION("onsemi MACPHY ethernet driver"); +MODULE_LICENSE("GPL");
Best regards Uwe
Attachments
- signature.asc [application/pgp-signature] 488 bytes