Re: [PATCH net-next v5 05/15] net: ethernet: oa_tc6: Move constant definitions to header file
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-06-15 20:55:10
Also in:
linux-devicetree, linux-doc, lkml
On Sun, 14 Jun 2026 10:00:21 -0700 Selvamani Rajagopal via B4 Relay wrote:
To help other source files within the module share the constant definitions, they are moved to a header file. The memory map selector(MMS) values that are defined in in Table 6 of OPEN Alliance 10BASE-T1x Serial Interface specification and currently used are added.
If you're adding kdoc on functions the return value must be documented (unless it's void of course): Warning: drivers/net/ethernet/oa_tc6/oa_tc6_ptp.c:34 No description found for return value of 'oa_tc6_ptp_register' Warning: drivers/net/ethernet/oa_tc6/oa_tc6_tstamp.c:143 function parameter 'stats' not described in 'oa_tc6_get_ts_stats' Warning: drivers/net/ethernet/oa_tc6/oa_tc6_tstamp.c:185 No description found for return value of 'oa_tc6_get_ts_info' Please note that net-next is closed during the merge window, please wait with the repost per: https://netdev.bots.linux.dev/net-next.html -- pw-bot: cr