Thread (17 messages) 17 messages, 2 authors, 22d ago

Re: [PATCH net 2/6] ipv6: fix error handling in ignore_routes_with_linkdown sysctl

From: Nicolas Dichtel <hidden>
Date: 2026-06-19 09:34:09

Le 18/06/2026 à 18:22, Fernando Fernandez Mancera a écrit :
When writing to the ignore_routes_with_linkdown sysctl, if
proc_dointvec() fails to parse the input, it returns a negative error
code. The current implementation is overwriting that error for write
operations.

This results in a silent failure, it returns a successful write although
the configuration was not modified at all. When modifying the "all"
variant it can also modify the configuration of existing interfaces to
the wrong value.

Fix this by checking the return value of proc_dointvec() and returning
early on failure.

Fixes: 35103d11173b ("net: ipv6 sysctl option to ignore routes when nexthop link is down")
Reviewed-by: Nicolas Dichtel <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help