Re: [PATCH net 1/6] ipv6: fix error handling in disable_ipv6 sysctl
From: Nicolas Dichtel <hidden>
Date: 2026-06-19 09:33:55
From: Nicolas Dichtel <hidden>
Date: 2026-06-19 09:33:55
Le 18/06/2026 à 18:22, Fernando Fernandez Mancera a écrit :
When writing to the disable_ipv6 sysctl, if proc_dointvec() fails to
parse the input, it returns a negative error code. The current
implementation is overwriting that error for write operations.
This results in a silent failure, it returns a successful write although
the configuration was not modified at all. When modifying the "all"
variant it can also modify the configuration of existing interfaces to
the wrong value.
Fix this by checking the return value of proc_dointvec() and returning
early on failure.
Fixes: 56d417b12e57 ("IPv6: Add 'autoconf' and 'disable_ipv6' module parameters")
Signed-off-by: Fernando Fernandez Mancera <redacted>Reviewed-by: Nicolas Dichtel <redacted>