Thread (5 messages) 5 messages, 5 authors, 20d ago

Re: [PATCH net v4] selftests/net/openvswitch: guard command substitutions against empty output

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-06-09 13:20:08
Also in: linux-kselftest

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni [off-list ref]:

On Fri,  5 Jun 2026 00:30:16 +0800 you wrote:
When ip-link output is unavailable, when the upcall daemon log has not
been written yet, or when pahole does not know the OVS drop subsystem
ID, the affected command substitutions silently produce empty strings.
The caller then passes empty sha= or pid= arguments to ovs_add_flow,
or matches against wrong drop reason codes, all without a diagnostic.

Add [ -z ] guards immediately after each assignment. For test_arp_ping,
also align the MAC extraction to use awk '/link\/ether/' as in
test_pop_vlan. The drop_reason guard returns ksft_skip because an
absent subsystem ID is an environment issue, not a test failure.

[...]
Here is the summary with links:
  - [net,v4] selftests/net/openvswitch: guard command substitutions against empty output
    https://git.kernel.org/netdev/net-next/c/9415471e01c1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help